From: John Benediktsson Date: Fri, 12 Jan 2024 16:44:12 +0000 (-0800) Subject: sequences.parser: simplify duplicate defition. X-Git-Url: https://gitweb.factorcode.org/gitweb.cgi?p=factor.git;a=commitdiff_plain;h=557313d38746a2629db1e2843f130d04c7858211 sequences.parser: simplify duplicate defition. currently, keep possibly poor "next" naming, since it was used in a few more places than "get+increment". both are kinda bad names i guess. --- diff --git a/basis/sequences/parser/parser.factor b/basis/sequences/parser/parser.factor index 2dc1659f7b..cee5fb4898 100644 --- a/basis/sequences/parser/parser.factor +++ b/basis/sequences/parser/parser.factor @@ -31,12 +31,7 @@ TUPLE: sequence-parser sequence n ; : advance ( sequence-parser -- sequence-parser ) [ 1 + ] change-n ; inline -: advance* ( sequence-parser -- ) - advance drop ; inline - -: next ( sequence-parser -- obj ) [ current ] [ advance* ] bi ; - -: get+increment ( sequence-parser -- char/f ) +: next ( sequence-parser -- char/f ) [ current ] [ advance drop ] bi ; inline :: skip-until ( ... sequence-parser quot: ( ... obj -- ... ? ) -- ... ) diff --git a/extra/c/lexer/lexer.factor b/extra/c/lexer/lexer.factor index 8869d59d58..5606dc46bf 100644 --- a/extra/c/lexer/lexer.factor +++ b/extra/c/lexer/lexer.factor @@ -51,7 +51,7 @@ IN: c.lexer } 1|| ] take-while :> string sequence-parser current quote-char = [ - sequence-parser advance* string + sequence-parser advance drop string ] [ start-n sequence-parser n<< f ] if ; diff --git a/extra/html/parser/parser.factor b/extra/html/parser/parser.factor index 9fc7e6295f..b9c09e41ac 100644 --- a/extra/html/parser/parser.factor +++ b/extra/html/parser/parser.factor @@ -46,7 +46,7 @@ SYMBOL: tagstack CHAR: \" (read-quote) ; : read-quote ( sequence-parser -- string ) - dup get+increment CHAR: ' = + dup next CHAR: ' = [ read-single-quote ] [ read-double-quote ] if ; : read-key ( sequence-parser -- string )