]> gitweb.factorcode.org Git - factor.git/log
factor.git
8 years agoREADME: https links instead of http.
Doug Coleman [Sat, 5 Mar 2016 19:42:26 +0000 (11:42 -0800)]
README: https links instead of http.

8 years agoip-parser: some cleanup, move ipv6 parsing here.
John Benediktsson [Sat, 5 Mar 2016 17:51:37 +0000 (09:51 -0800)]
ip-parser: some cleanup, move ipv6 parsing here.

8 years agolibtls.ffi: fix platforms file to not have empty line.
John Benediktsson [Sat, 5 Mar 2016 15:44:37 +0000 (07:44 -0800)]
libtls.ffi: fix platforms file to not have empty line.

8 years agoImport a few extra JSON tests from Jansson
Benjamin Pollack [Sat, 5 Mar 2016 14:56:18 +0000 (09:56 -0500)]
Import a few extra JSON tests from Jansson

Fixes #1189

8 years agoMake <inet4> and <ipv4> use ip-parser:parse-ipv4 1542/head
Benjamin Pollack [Sat, 5 Mar 2016 14:11:56 +0000 (09:11 -0500)]
Make <inet4> and <ipv4> use ip-parser:parse-ipv4

Fixes #1209

8 years agolibtls.ffi: Depends on unix.types, fix Windows.
Doug Coleman [Sat, 5 Mar 2016 11:02:38 +0000 (03:02 -0800)]
libtls.ffi: Depends on unix.types, fix Windows.

8 years agoio.sockets.secure.windows: Try to fix compile error.
Doug Coleman [Sat, 5 Mar 2016 10:57:39 +0000 (02:57 -0800)]
io.sockets.secure.windows: Try to fix compile error.

8 years agoAllow specifying vocabulary roots on the command line
Benjamin Pollack [Thu, 3 Mar 2016 19:24:54 +0000 (14:24 -0500)]
Allow specifying vocabulary roots on the command line

Fixes #1498

8 years agoUse proper SI prefixes in memory flag docs
Benjamin Pollack [Fri, 4 Mar 2016 18:34:42 +0000 (13:34 -0500)]
Use proper SI prefixes in memory flag docs

8 years agoopenssl: More ciphers.
Doug Coleman [Fri, 4 Mar 2016 18:42:35 +0000 (18:42 +0000)]
openssl: More ciphers.

8 years agoopenssl: call SSL_CTX_set_ecdh_auto() for forward secrecy.
Doug Coleman [Fri, 4 Mar 2016 18:05:09 +0000 (10:05 -0800)]
openssl: call SSL_CTX_set_ecdh_auto() for forward secrecy.

8 years agoopenssl.libssl: Add more constants.
Doug Coleman [Fri, 4 Mar 2016 18:05:02 +0000 (10:05 -0800)]
openssl.libssl: Add more constants.

8 years agoopenssl: support more protocols for forward secrecy.
Doug Coleman [Fri, 4 Mar 2016 17:19:08 +0000 (09:19 -0800)]
openssl: support more protocols for forward secrecy.

8 years agoopenssl: Prefer tls1.2. Only use secure ciphers.
Doug Coleman [Fri, 4 Mar 2016 17:15:12 +0000 (09:15 -0800)]
openssl: Prefer tls1.2. Only use secure ciphers.

8 years agoalien.libraries: Add a way to see if a dll has a function.
Doug Coleman [Fri, 4 Mar 2016 17:14:49 +0000 (09:14 -0800)]
alien.libraries: Add a way to see if a dll has a function.

8 years agocommand-line: More consistent command-line docs, fix MB -> kb for callback heap size
Doug Coleman [Fri, 4 Mar 2016 01:28:53 +0000 (17:28 -0800)]
command-line: More consistent command-line docs, fix MB -> kb for callback heap size

8 years agocommand-line.startup: document more command line flags. we already have -nosignals...
Doug Coleman [Fri, 4 Mar 2016 00:53:24 +0000 (16:53 -0800)]
command-line.startup: document more command line flags. we already have -nosignals, but it was hidden in the source code. Fix spacing for default image. Closes #1514.

8 years agourls: fix docs
Doug Coleman [Fri, 4 Mar 2016 00:15:11 +0000 (16:15 -0800)]
urls: fix docs

8 years agohashtables: remove 2hashtable (not really used).
John Benediktsson [Thu, 3 Mar 2016 22:36:48 +0000 (14:36 -0800)]
hashtables: remove 2hashtable (not really used).

8 years agourls: fix unit test
Doug Coleman [Thu, 3 Mar 2016 22:21:12 +0000 (14:21 -0800)]
urls: fix unit test

8 years agoDo not attempt to set an SNI hostname on a server
Benjamin Pollack [Thu, 3 Mar 2016 21:40:50 +0000 (16:40 -0500)]
Do not attempt to set an SNI hostname on a server

8 years agocore: I messed up the refactoring. with-scope should go away, but so should with...
Doug Coleman [Thu, 3 Mar 2016 19:54:33 +0000 (11:54 -0800)]
core: I messed up the refactoring. with-scope should go away, but so should with-variables with an empty hashtable too.

8 years agoAdd an SNI-based http.client test
Benjamin Pollack [Thu, 3 Mar 2016 17:45:03 +0000 (12:45 -0500)]
Add an SNI-based http.client test

8 years agoAdd SNI support to Factor
Benjamin Pollack [Wed, 2 Mar 2016 23:29:59 +0000 (18:29 -0500)]
Add SNI support to Factor

Fixes #1527

8 years agocore: Don't use with-scope. H{ } clone [ ] with-variables is the same thing and is...
Doug Coleman [Thu, 3 Mar 2016 01:18:42 +0000 (17:18 -0800)]
core: Don't use with-scope. H{ } clone [ ] with-variables is the same thing and is more explicit.

8 years agohashtables: add a 2hashtable word that is like associate but for two key/value pairs.
Doug Coleman [Thu, 3 Mar 2016 01:16:05 +0000 (17:16 -0800)]
hashtables: add a 2hashtable word that is like associate but for two key/value pairs.

8 years agodocs, smpt-gmail: fix for people not using 2FA + formatting
Jon Harper [Wed, 2 Mar 2016 18:10:10 +0000 (19:10 +0100)]
docs, smpt-gmail: fix for people not using 2FA + formatting

8 years agoDump everything before TLSv1 1536/head
Benjamin Pollack [Wed, 2 Mar 2016 00:42:08 +0000 (19:42 -0500)]
Dump everything before TLSv1

All versions of SSL are deprecated and have major security issues. Just
kill the whole thing. If you want to deliberately expose yourself to
POODLE, you can do it on your own time.

8 years agoio.sockets.secure.openssl: Nuke RSA.
Doug Coleman [Tue, 1 Mar 2016 22:02:47 +0000 (14:02 -0800)]
io.sockets.secure.openssl: Nuke RSA.

8 years agoalien.syntax: Fix CALLBACK: syntax again in another place
Doug Coleman [Tue, 1 Mar 2016 21:07:37 +0000 (13:07 -0800)]
alien.syntax: Fix CALLBACK: syntax again in another place

8 years agoalien.syntax: Fix docs for CALLBACK: (no semi)
Doug Coleman [Tue, 1 Mar 2016 20:42:17 +0000 (12:42 -0800)]
alien.syntax: Fix docs for CALLBACK: (no semi)

8 years agoforestdb.ffi: Update ffi.
Doug Coleman [Tue, 1 Mar 2016 20:40:11 +0000 (12:40 -0800)]
forestdb.ffi: Update ffi.

8 years agobootstrap.image: docs
Björn Lindqvist [Sun, 28 Feb 2016 17:49:41 +0000 (18:49 +0100)]
bootstrap.image: docs

8 years agovm/contexts.cpp: We are only deleting half the contexts because we increment the...
Doug Coleman [Tue, 1 Mar 2016 08:19:43 +0000 (00:19 -0800)]
vm/contexts.cpp: We are only deleting half the contexts because we increment the iter twice per loop! Fixes #1534. Thanks clang!

8 years agoVM: nitpick fix of filenames in comments
Björn Lindqvist [Sun, 28 Feb 2016 00:23:59 +0000 (01:23 +0100)]
VM: nitpick fix of filenames in comments

8 years agoVM: simplifies factor_vm::determine_inline_cache_type
Björn Lindqvist [Sun, 28 Feb 2016 00:10:12 +0000 (01:10 +0100)]
VM: simplifies factor_vm::determine_inline_cache_type

8 years agocompiler.*: more docs
Björn Lindqvist [Sun, 28 Feb 2016 00:01:38 +0000 (01:01 +0100)]
compiler.*: more docs

8 years agounix.linux.proc: add bugs line.
Doug Coleman [Sat, 27 Feb 2016 00:28:58 +0000 (00:28 +0000)]
unix.linux.proc: add bugs line.

8 years agoFix "doesnt" typo.
John Benediktsson [Fri, 26 Feb 2016 16:56:25 +0000 (08:56 -0800)]
Fix "doesnt" typo.

8 years agoeditors.visual-studio-code: Try to find ``Code`` executable on linux.
Doug Coleman [Wed, 24 Feb 2016 02:45:25 +0000 (18:45 -0800)]
editors.visual-studio-code: Try to find ``Code`` executable on linux.

8 years agoopenssl.libssl: Add some more constants. Move things around a little and add SSL_ctrl...
Doug Coleman [Wed, 24 Feb 2016 02:24:41 +0000 (18:24 -0800)]
openssl.libssl: Add some more constants. Move things around a little and add SSL_ctrl() binding.

8 years agoopenssl: only set RSA keys if required to do so 1532/head
Benjamin Pollack [Tue, 23 Feb 2016 13:09:07 +0000 (08:09 -0500)]
openssl: only set RSA keys if required to do so

Modern OpenSSL and LibreSSL both do not require SSL_CTX_set_tmp_rsa to
be called unless SSL_CTX_need_tmp_rsa returns true, and LibreSSL and
OpenSSL compiled with deprecation warnings both will fail if this
happens. This commit resolves that.

With this change, it becomes possible to use LibreSSL in place of
OpenSSL with Factor.

8 years agoUpdate OpenSSL calls to work with LibreSSL/newer OpenSSL
Benjamin Pollack [Mon, 22 Feb 2016 18:37:54 +0000 (13:37 -0500)]
Update OpenSSL calls to work with LibreSSL/newer OpenSSL

RSA_generate_key has been deprecated, and is not available in either
LibreSSL or newer OpenSSL that are not compiled with deprecated call
support. This commit switches to the still-supported
RSA_generate_key_ex, which is supported by both libraries.

Note that this is still insufficient for Factor to work under LibreSSL,
though we now get a call further than before.

8 years agoio.sockets: remove send-n-times, broadcast-n-times.
Doug Coleman [Sun, 21 Feb 2016 02:37:08 +0000 (18:37 -0800)]
io.sockets: remove send-n-times, broadcast-n-times.

8 years agoforestdb.lib: fix using
Doug Coleman [Sat, 20 Feb 2016 03:22:19 +0000 (19:22 -0800)]
forestdb.lib: fix using

8 years agoio.sockets: Add more utility words for working with udp.
Doug Coleman [Sat, 20 Feb 2016 02:58:43 +0000 (18:58 -0800)]
io.sockets: Add more utility words for working with udp.

8 years agoforestdb: allow setting byte-arrays.
Doug Coleman [Sat, 20 Feb 2016 01:58:37 +0000 (17:58 -0800)]
forestdb: allow setting byte-arrays.

8 years agofactor: update repository location to factor/factor
Doug Coleman [Fri, 19 Feb 2016 21:48:00 +0000 (13:48 -0800)]
factor: update repository location to factor/factor

8 years agoAdd support for LibreSSL's libtls library 1528/head
Benjamin Pollack [Thu, 18 Feb 2016 19:29:54 +0000 (14:29 -0500)]
Add support for LibreSSL's libtls library

These are just the low-level FFI bindings; high-level bindings (and
maybe an alternative implementation of io.sockets.secure) will come in
a later commit.

8 years agoforestdb: Update for new apis. Fix a bug with iteration, fix a test case that changed...
Doug Coleman [Thu, 18 Feb 2016 18:09:44 +0000 (10:09 -0800)]
forestdb: Update for new apis. Fix a bug with iteration, fix a test case that changed behavior.

8 years agojson.prettyprint: Add a simple json prettyprinter.
Doug Coleman [Wed, 17 Feb 2016 23:50:32 +0000 (17:50 -0600)]
json.prettyprint: Add a simple json prettyprinter.

8 years agoFix incorrect alien.syntax documentation for FUNCTION:
Benjamin Pollack [Wed, 17 Feb 2016 17:23:09 +0000 (12:23 -0500)]
Fix incorrect alien.syntax documentation for FUNCTION:

The library docs indicate that you need a semicolon at the end of
a `FUNCTION:` definition, but that's actually a syntax error. Likewise,
while the parentheses and commas may at one point have been optional,
they emphatically aren't anymore. This patch brings the documentation in
line with the code.

8 years agoMake Visual Studio Code integration go directly to lines 1525/head
Benjamin Pollack [Mon, 15 Feb 2016 20:42:31 +0000 (15:42 -0500)]
Make Visual Studio Code integration go directly to lines

8 years agoAdd Mac support for Visual Studio Code 1524/head
Benjamin Pollack [Fri, 12 Feb 2016 15:06:50 +0000 (10:06 -0500)]
Add Mac support for Visual Studio Code

8 years agox11.xim: fix "cannot execute a word before it has been compiled" bug.
John Benediktsson [Sun, 10 Jan 2016 00:16:58 +0000 (16:16 -0800)]
x11.xim: fix "cannot execute a word before it has been compiled" bug.

8 years agodocs, ffi: more explicit c-string conversions docs
Jon Harper [Sat, 9 Jan 2016 17:30:35 +0000 (18:30 +0100)]
docs, ffi: more explicit c-string conversions docs

8 years agodocs, wrapping structs: add links to memory>struct and <direct-T-array>
Jon Harper [Sat, 9 Jan 2016 17:27:46 +0000 (18:27 +0100)]
docs, wrapping structs: add links to memory>struct and <direct-T-array>

8 years agoffi docs, C unions are UNION-STRUCT: in factor
Jon Harper [Sat, 9 Jan 2016 16:22:49 +0000 (17:22 +0100)]
ffi docs, C unions are UNION-STRUCT: in factor

8 years agox11.xim: lookup-string, always use same buf and simplify 1523/head
Jon Harper [Sat, 9 Jan 2016 19:21:13 +0000 (20:21 +0100)]
x11.xim: lookup-string, always use same buf and simplify

8 years agox11 xlib, use Xutf8LookupString instead of XwcLookupString
Jon Harper [Sat, 9 Jan 2016 18:06:26 +0000 (19:06 +0100)]
x11 xlib, use Xutf8LookupString instead of XwcLookupString

XwcLookupString uses a locale dependant encoding, but was always
decoded using utf16. On my system, it was not utf16 that was used.
Xutf8LookupString always uses utf8 so it should work everywhere

8 years agotools.deploy: bump size.
John Benediktsson [Wed, 30 Dec 2015 20:49:34 +0000 (12:49 -0800)]
tools.deploy: bump size.

8 years agochecksums: speedup add-checksum-bytes by using the slice.
John Benediktsson [Wed, 30 Dec 2015 17:40:58 +0000 (09:40 -0800)]
checksums: speedup add-checksum-bytes by using the slice.

8 years agouu: simplify a little bit.
John Benediktsson [Sun, 27 Dec 2015 18:00:22 +0000 (10:00 -0800)]
uu: simplify a little bit.

8 years agotools.deploy: add a MAIN:.
John Benediktsson [Sat, 26 Dec 2015 05:11:21 +0000 (21:11 -0800)]
tools.deploy: add a MAIN:.

8 years agotools.test: makes <test-failure> public
Björn Lindqvist [Thu, 17 Dec 2015 22:49:57 +0000 (23:49 +0100)]
tools.test: makes <test-failure> public

8 years agofuel: fix doc on starting fuel server
Sankaranarayanan Viswanathan [Thu, 17 Dec 2015 19:29:22 +0000 (00:59 +0530)]
fuel: fix doc on starting fuel server

8 years agobenchmark: wrap the error in <test-failure>
Björn Lindqvist [Thu, 17 Dec 2015 17:57:52 +0000 (18:57 +0100)]
benchmark: wrap the error in <test-failure>

Piggybacks on the test-failure error. word so that we get a traceback if
an error occurs during benchmarking. To make it easier to debug the "No
suitable arithmetic method" random error #1484

8 years agobenchmark: refactoring to not use dynamic variables + unit tests
Björn Lindqvist [Thu, 17 Dec 2015 16:09:00 +0000 (17:09 +0100)]
benchmark: refactoring to not use dynamic variables + unit tests

8 years agotools.deploy: bump sizes, sigh.
John Benediktsson [Mon, 14 Dec 2015 18:21:35 +0000 (10:21 -0800)]
tools.deploy: bump sizes, sigh.

8 years agobootstrap.image.tests: I screwed up the test case values -- fix them
Björn Lindqvist [Mon, 14 Dec 2015 12:56:35 +0000 (13:56 +0100)]
bootstrap.image.tests: I screwed up the test case values -- fix them

8 years agovm: remove vm-field-offset and context-field-offset
Björn Lindqvist [Mon, 14 Dec 2015 08:29:18 +0000 (09:29 +0100)]
vm: remove vm-field-offset and context-field-offset

Shorter to just write "vm offset-of" and "context offset-of"

8 years agobootstrap.image.tests: new tests & fix for 32bit test failure
Björn Lindqvist [Mon, 14 Dec 2015 05:53:05 +0000 (06:53 +0100)]
bootstrap.image.tests: new tests & fix for 32bit test failure

8 years agotools.deploy: bump deploy test sizes.
John Benediktsson [Sun, 13 Dec 2015 22:25:45 +0000 (14:25 -0800)]
tools.deploy: bump deploy test sizes.

8 years agotools.image-analyzer: fix help-lint docs.
John Benediktsson [Sun, 13 Dec 2015 19:46:13 +0000 (11:46 -0800)]
tools.image-analyzer: fix help-lint docs.

8 years agotools.deploy: bump test sizes.
John Benediktsson [Sun, 13 Dec 2015 17:02:39 +0000 (09:02 -0800)]
tools.deploy: bump test sizes.

8 years agosystem-info.linux.tests: fix test, linux is at 4.2.x now
Björn Lindqvist [Sun, 13 Dec 2015 12:38:40 +0000 (13:38 +0100)]
system-info.linux.tests: fix test, linux is at 4.2.x now

8 years agoVM: removes a few methods related to relocation handling
Björn Lindqvist [Sun, 13 Dec 2015 07:23:55 +0000 (08:23 +0100)]
VM: removes a few methods related to relocation handling

They are only used once, so it is simpler to "inline" them

8 years agoVM: the compute_vm_address method can be removed
Björn Lindqvist [Sun, 13 Dec 2015 07:20:20 +0000 (08:20 +0100)]
VM: the compute_vm_address method can be removed

8 years agoVM: more fine-grained control over which special objects to save
Björn Lindqvist [Sun, 13 Dec 2015 07:10:36 +0000 (08:10 +0100)]
VM: more fine-grained control over which special objects to save

It removes a few roots that doesn't need to be saved in the image and
can save a few hundred bytes.

8 years agotools.image-analyzer.graphviz: output the root nodes in a graph cluster, looks pretty...
Björn Lindqvist [Sun, 13 Dec 2015 06:59:39 +0000 (07:59 +0100)]
tools.image-analyzer.graphviz: output the root nodes in a graph cluster, looks pretty neat

8 years agotools.image-analyzer: now also loads absolute relocation pointers
Björn Lindqvist [Sun, 13 Dec 2015 06:54:04 +0000 (07:54 +0100)]
tools.image-analyzer: now also loads absolute relocation pointers

8 years agotools.image-analyzer: now relocation pointers are decoded too -> nicer graphs
Björn Lindqvist [Sat, 12 Dec 2015 11:03:08 +0000 (12:03 +0100)]
tools.image-analyzer: now relocation pointers are decoded too -> nicer graphs

8 years agoVM: the rel_type() and rel_offset() accessors in instruction_operand can be removed
Björn Lindqvist [Sat, 12 Dec 2015 03:02:53 +0000 (04:02 +0100)]
VM: the rel_type() and rel_offset() accessors in instruction_operand can be removed

8 years agodocs: using $maybe.
John Benediktsson [Sat, 12 Dec 2015 01:05:45 +0000 (17:05 -0800)]
docs: using $maybe.

8 years agoVM: now special-objects is used for -1, 0, 1 and t
Björn Lindqvist [Thu, 10 Dec 2015 09:07:57 +0000 (10:07 +0100)]
VM: now special-objects is used for -1, 0, 1 and t

The fields in the image_header aren't read or written to but I haven't
changed the format yet.

8 years agoVM: put the singletons t, -1, 0 and 1 in the special objects table
Björn Lindqvist [Wed, 9 Dec 2015 20:31:13 +0000 (21:31 +0100)]
VM: put the singletons t, -1, 0 and 1 in the special objects table

Having them there instead of as fields in the vm struct removes a bunch
of special handling. This commit just adds them and doesn't remove the
old ones to avoid potential chicken-and-egg bootstrap problems.

8 years agoui.backend.gtk: only run the tests on linux
Björn Lindqvist [Tue, 8 Dec 2015 08:46:30 +0000 (09:46 +0100)]
ui.backend.gtk: only run the tests on linux

8 years agoio.encodings: doc fix
Björn Lindqvist [Tue, 8 Dec 2015 03:21:32 +0000 (04:21 +0100)]
io.encodings: doc fix

8 years agocompiler.tests.callstack-overflow: disable test for os x 64, see #1478
Björn Lindqvist [Tue, 8 Dec 2015 01:16:51 +0000 (02:16 +0100)]
compiler.tests.callstack-overflow: disable test for os x 64, see #1478

8 years agotools.image-analyzer: test failure fix
Björn Lindqvist [Tue, 8 Dec 2015 01:12:30 +0000 (02:12 +0100)]
tools.image-analyzer: test failure fix

8 years agotools.image-analyzer.graphviz: new vocab for making graphs of the loaded heaps
Björn Lindqvist [Mon, 7 Dec 2015 08:06:12 +0000 (09:06 +0100)]
tools.image-analyzer.graphviz: new vocab for making graphs of the loaded heaps

8 years agographviz.dot: better string escaping using unparse-string
Björn Lindqvist [Mon, 7 Dec 2015 07:37:08 +0000 (08:37 +0100)]
graphviz.dot: better string escaping using unparse-string

8 years agotools.image-analyzer.*: wrap read objects in heap-node tuples with their addresses
Björn Lindqvist [Mon, 7 Dec 2015 03:20:43 +0000 (04:20 +0100)]
tools.image-analyzer.*: wrap read objects in heap-node tuples with their addresses

8 years agoDocs: more docs for vocabs in core/
Björn Lindqvist [Sat, 5 Dec 2015 15:34:46 +0000 (16:34 +0100)]
Docs: more docs for vocabs in core/

8 years agotools.test: print the callstack in test failures
Björn Lindqvist [Thu, 3 Dec 2015 11:00:40 +0000 (12:00 +0100)]
tools.test: print the callstack in test failures

So when mason reports a test failure it should include the whole
callstack. That should make it easier to catch the "No suitable
arithmetic method" random error that is hard to debug without a
callstack.

8 years agoVM: refactors the prepare_boot_image method
Björn Lindqvist [Fri, 4 Dec 2015 12:57:57 +0000 (13:57 +0100)]
VM: refactors the prepare_boot_image method

easier to read if the methods compile_all_words and
initialize_all_quotations which are only used once are "inlined"

8 years agobootstrap.*: fix for #1512, load docs after everything else
Björn Lindqvist [Fri, 4 Dec 2015 12:29:29 +0000 (13:29 +0100)]
bootstrap.*: fix for #1512, load docs after everything else

By making it so the help component is loaded almost last, all vocabs are loaded without docs and only then are they loaded. It should make it so you don't get cyclic dependency problems in doc files during bootstrapping.

8 years agobootstrap.stage2: more logging output and fix for #1444
Björn Lindqvist [Fri, 4 Dec 2015 12:16:21 +0000 (13:16 +0100)]
bootstrap.stage2: more logging output and fix for #1444

The error clearing needs to happen almost last so that an error is not
set in the image.

8 years agoFUEL: slightly improved font-locking for alien functions and aliases
Björn Lindqvist [Fri, 4 Dec 2015 11:43:01 +0000 (12:43 +0100)]
FUEL: slightly improved font-locking for alien functions and aliases

8 years agoui.backend.gtk: set the active? to 100 in on-map, should fix #1506
Björn Lindqvist [Thu, 3 Dec 2015 23:57:19 +0000 (00:57 +0100)]
ui.backend.gtk: set the active? to 100 in on-map, should fix #1506

what now happens is that configure events are skipped until the first
on-map signal is fired. seem to work fine in a variety of wm:s. if this
works well we can return active? to be plain boolean.