From 28c179cf5903676aa1237b4eee7722ff6eb58043 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bj=C3=B6rn=20Lindqvist?= Date: Sun, 4 Oct 2015 02:26:02 +0200 Subject: [PATCH] furnace.recaptcha: logic in recaptcha-url was wrong, fix and test case --- basis/furnace/recaptcha/recaptcha-tests.factor | 10 ++++++++++ basis/furnace/recaptcha/recaptcha.factor | 3 +-- 2 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 basis/furnace/recaptcha/recaptcha-tests.factor diff --git a/basis/furnace/recaptcha/recaptcha-tests.factor b/basis/furnace/recaptcha/recaptcha-tests.factor new file mode 100644 index 0000000000..7f18184eef --- /dev/null +++ b/basis/furnace/recaptcha/recaptcha-tests.factor @@ -0,0 +1,10 @@ +USING: furnace.recaptcha.private tools.test urls ; +IN: furnace.recaptcha.tests + +{ + URL" http://www.google.com/recaptcha/api/challenge" + URL" https://www.google.com/recaptcha/api/challenge" +} [ + f recaptcha-url + t recaptcha-url +] unit-test diff --git a/basis/furnace/recaptcha/recaptcha.factor b/basis/furnace/recaptcha/recaptcha.factor index 3ae20f14bb..fff1f61610 100644 --- a/basis/furnace/recaptcha/recaptcha.factor +++ b/basis/furnace/recaptcha/recaptcha.factor @@ -39,8 +39,7 @@ M: recaptcha call-responder* XML] ; : recaptcha-url ( secure? -- ? ) - "http://www.google.com/recaptcha/api/challenge" - "https://www.google.com/recaptcha/api/challenge" ? + "https" "http" ? "://www.google.com/recaptcha/api/challenge" append recaptcha-error cget [ "?error=" glue ] when* >url ; : render-recaptcha ( -- xml ) -- 2.34.1