From 791776f9b9e31e7e3e7fe779d365f50dcec5c0cc Mon Sep 17 00:00:00 2001
From: John Benediktsson <mrjbq7@gmail.com>
Date: Mon, 23 Oct 2023 10:57:52 -0700
Subject: [PATCH] math.vectors: rename vsupremum/vinfimum

---
 basis/math/rectangles/rectangles.factor | 3 +--
 basis/math/vectors/vectors-docs.factor  | 6 +++---
 basis/math/vectors/vectors.factor       | 7 +++++--
 extra/benchmark/simd-1/simd-1.factor    | 2 +-
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/basis/math/rectangles/rectangles.factor b/basis/math/rectangles/rectangles.factor
index 8e0fddeee1..6c658ab1a1 100644
--- a/basis/math/rectangles/rectangles.factor
+++ b/basis/math/rectangles/rectangles.factor
@@ -51,8 +51,7 @@ M: rect contains-point?
     (rect-union) <extent-rect> ;
 
 : rect-containing ( points -- rect )
-    [ vsupremum ] [ vinfimum ] bi
-    [ nip ] [ v- ] 2bi <rect> ;
+    [ vmaximum ] [ vminimum ] bi [ nip ] [ v- ] 2bi <rect> ;
 
 : rect-min ( rect dim -- rect' )
     [ rect-bounds ] dip vmin <rect> ;
diff --git a/basis/math/vectors/vectors-docs.factor b/basis/math/vectors/vectors-docs.factor
index a5d1ba909d..e1f3d47050 100644
--- a/basis/math/vectors/vectors-docs.factor
+++ b/basis/math/vectors/vectors-docs.factor
@@ -88,8 +88,8 @@ $nl
     vmax
     vmin
     vclamp
-    vsupremum
-    vinfimum
+    vmaximum
+    vminimum
 }
 "Bitwise operations:"
 { $subsections
@@ -512,7 +512,7 @@ HELP: norm
 
 HELP: l-infinity-norm
 { $values { "k" sequence } { "x" "a non-negative real number" } }
-{ $contract "Computes the norm (size) of " { $snippet "k" } " in 𝑙∞ (" { $snippet "L^∞" } ") vector space, usually written ∥･∥∞. For a mathematical vector, this is simply its " { $link supremum } "." }
+{ $contract "Computes the norm (size) of " { $snippet "k" } " in 𝑙∞ (" { $snippet "L^∞" } ") vector space, usually written ∥･∥∞. For a mathematical vector, this is simply its " { $link maximum } "." }
 { $examples
     { $example
         "USING: math.vectors prettyprint ;"
diff --git a/basis/math/vectors/vectors.factor b/basis/math/vectors/vectors.factor
index 12213627f7..326cbede67 100644
--- a/basis/math/vectors/vectors.factor
+++ b/basis/math/vectors/vectors.factor
@@ -213,8 +213,11 @@ M: object v?
 : vceiling ( v -- w ) [ ceiling ] map ;
 : vtruncate ( v -- w ) [ truncate ] map ;
 
-: vsupremum ( seq -- vmax ) [ ] [ vmax ] map-reduce ; inline
-: vinfimum ( seq -- vmin ) [ ] [ vmin ] map-reduce ; inline
+: vmaximum ( seq -- vmax ) [ ] [ vmax ] map-reduce ; inline
+: vminimum ( seq -- vmin ) [ ] [ vmin ] map-reduce ; inline
+
+ALIAS: vsupremum vmaximum deprecated
+ALIAS: vinfimum vminimum deprecated
 
 GENERIC: vdot ( u v -- x )
 M: object vdot [ * ] [ + ] 2map-reduce ; inline
diff --git a/extra/benchmark/simd-1/simd-1.factor b/extra/benchmark/simd-1/simd-1.factor
index 3f921eb781..ee31a8ba6a 100644
--- a/extra/benchmark/simd-1/simd-1.factor
+++ b/extra/benchmark/simd-1/simd-1.factor
@@ -20,7 +20,7 @@ IN: benchmark.simd-1
     [ number>string ] { } map-as ", " join print ; inline
 
 : simd-benchmark ( len -- )
-    >fixnum make-points [ normalize-points ] [ vsupremum ] bi print-point ;
+    >fixnum make-points [ normalize-points ] [ vmaximum ] bi print-point ;
 
 : simd-1-benchmark ( -- )
     10 [ 500000 simd-benchmark ] times ;
-- 
2.34.1