From aeff3f35c8896e0e7f9c0005f9e65417ea488516 Mon Sep 17 00:00:00 2001 From: Doug Coleman Date: Sun, 21 Mar 2021 10:05:57 -0500 Subject: [PATCH] http: Use Uppercase For Header Names They get normalized anyway but most clients seem to use Upper Case. --- basis/http/client/client-tests.factor | 4 ++-- basis/http/client/client.factor | 4 ++-- basis/http/http.factor | 10 +++++----- extra/visionect/visionect.factor | 6 +++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/basis/http/client/client-tests.factor b/basis/http/client/client-tests.factor index ceab96a6d9..5d8e11aaaa 100644 --- a/basis/http/client/client-tests.factor +++ b/basis/http/client/client-tests.factor @@ -14,7 +14,7 @@ IN: http.client.tests { method "GET" } { version "1.1" } { cookies V{ } } - { header H{ { "connection" "close" } { "user-agent" "Factor http.client" } } } + { header H{ { "Connection" "close" } { "User-Agent" "Factor http.client" } } } { redirects 10 } } } [ @@ -29,7 +29,7 @@ IN: http.client.tests { method "GET" } { version "1.1" } { cookies V{ } } - { header H{ { "connection" "close" } { "user-agent" "Factor http.client" } } } + { header H{ { "Connection" "close" } { "User-Agent" "Factor http.client" } } } { redirects 10 } } } [ diff --git a/basis/http/client/client.factor b/basis/http/client/client.factor index 9acdd247d6..3b8e30642a 100644 --- a/basis/http/client/client.factor +++ b/basis/http/client/client.factor @@ -57,10 +57,10 @@ ERROR: download-failed response ; ] if ; : set-host-header ( request header -- request header ) - over url>> unparse-host "host" pick set-at ; + over url>> unparse-host "Host" pick set-at ; : set-cookie-header ( header cookies -- header ) - unparse-cookie "cookie" pick set-at ; + unparse-cookie "Cookie" pick set-at ; : ?set-basic-auth ( header url name -- header ) swap [ diff --git a/basis/http/http.factor b/basis/http/http.factor index e0f8528f8d..43420af92e 100644 --- a/basis/http/http.factor +++ b/basis/http/http.factor @@ -160,8 +160,8 @@ TUPLE: request >>proxy-url H{ } clone >>header V{ } clone >>cookies - "close" "connection" set-header - "Factor http.client" "user-agent" set-header + "close" "Connection" set-header + "Factor http.client" "User-Agent" set-header max-redirects >>redirects ; : header ( request/response key -- value ) @@ -183,9 +183,9 @@ TUPLE: response response new "1.1" >>version H{ } clone >>header - "close" "connection" set-header - now timestamp>http-string "date" set-header - "Factor http.server" "server" set-header + "close" "Connection" set-header + now timestamp>http-string "Date" set-header + "Factor http.server" "Server" set-header utf8 >>content-encoding V{ } clone >>cookies ; diff --git a/extra/visionect/visionect.factor b/extra/visionect/visionect.factor index c4e159b2ba..5ae0a01357 100644 --- a/extra/visionect/visionect.factor +++ b/extra/visionect/visionect.factor @@ -29,8 +29,8 @@ SYMBOL: visionect-api-secret visionect-api-key get ":" rot 3append ; : set-visionect-headers ( request -- request ) - now timestamp>http-string "date" set-header - dup visionect-authorization "authorization" set-header ; + now timestamp>http-string "Date" set-header + dup visionect-authorization "Authorization" set-header ; : visionect-request ( request -- data ) set-visionect-headers http-request nip ; @@ -50,7 +50,7 @@ SYMBOL: visionect-api-secret : visionect-post ( post-data path -- data ) visionect-url dup post-data>> dup post-data? - [ content-type>> "content-type" set-header ] [ drop ] if + [ content-type>> "Content-Type" set-header ] [ drop ] if visionect-request ; PRIVATE> -- 2.34.1