]> gitweb.factorcode.org Git - factor.git/commitdiff
compiler.cfg.*: detached the normalize-height and schedule-instructions passes
authorBjörn Lindqvist <bjourne@gmail.com>
Wed, 31 Dec 2014 20:51:15 +0000 (21:51 +0100)
committerDoug Coleman <doug.coleman@gmail.com>
Thu, 22 Jan 2015 20:17:20 +0000 (12:17 -0800)
those stages cause uninitialized "holes" in the stacks which in turn
causes gc errors if stack underflows occur

basis/compiler/cfg/finalization/finalization.factor
basis/compiler/cfg/optimizer/optimizer.factor

index 249398da56524672d123662d4a1a73ec1fbe1bf5..3c1fab30af88100b68fb78d3e1693c1639d90205 100644 (file)
@@ -2,15 +2,13 @@
 ! See http://factorcode.org/license.txt for BSD license.
 USING: compiler.cfg.build-stack-frame compiler.cfg.gc-checks
 compiler.cfg.linear-scan compiler.cfg.representations
-compiler.cfg.save-contexts compiler.cfg.scheduling
-compiler.cfg.ssa.destruction compiler.cfg.stacks.vacant
-compiler.cfg.utilities compiler.cfg.write-barrier ;
+compiler.cfg.save-contexts compiler.cfg.ssa.destruction
+compiler.cfg.stacks.vacant compiler.cfg.utilities compiler.cfg.write-barrier ;
 IN: compiler.cfg.finalization
 
 : finalize-cfg ( cfg -- )
     {
         select-representations
-        schedule-instructions
         insert-gc-checks
         eliminate-write-barriers
         compute-vacant-sets
index 356ae773ad0d9a16a4a9fcd134a3397e87362bd0..167431562910ea5e73ea79d0aa3ee31686a56957 100644 (file)
@@ -6,7 +6,6 @@ compiler.cfg.block-joining
 compiler.cfg.branch-splitting
 compiler.cfg.copy-prop
 compiler.cfg.dce
-compiler.cfg.height
 compiler.cfg.ssa.construction
 compiler.cfg.tco
 compiler.cfg.useless-conditionals
@@ -21,7 +20,6 @@ IN: compiler.cfg.optimizer
         delete-useless-conditionals
         split-branches
         join-blocks
-        normalize-height
         construct-ssa
         alias-analysis
         value-numbering