cleaning up html.parser

diff --git a/extra/html/parser/analyzer/analyzer.factor b/extra/html/parser/analyzer/analyzer.factor
index b82b5662dc0a28adb3227338883d20983af48630..5690ae32f2409bf049563a030feefd4c0338d398 100755 (executable)
--- a/extra/html/parser/analyzer/analyzer.factor
+++ b/extra/html/parser/analyzer/analyzer.factor
@@ -1,7 +1,7 @@
 USING: assocs html.parser kernel math sequences strings ascii
 arrays generalizations shuffle unicode.case namespaces make
-splitting http sequences.lib accessors io combinators
-http.client urls ;
+splitting http accessors io combinators http.client urls
+fry sequences.lib ;
 IN: html.parser.analyzer
 
 TUPLE: link attributes clickable ;
@@ -9,56 +9,55 @@ TUPLE: link attributes clickable ;
 : scrape-html ( url -- vector )
     http-get nip parse-html ;
 
-: (find-relative)
-    [ >r + dup r> ?nth* [ 2drop f f ] unless ] [ 2drop f ] if ; inline
+: find-all ( seq quot -- alist )
+   [ <enum> >alist ] [ '[ second @ ] ] bi* filter ; inline
 
-: find-relative ( seq quot n -- i elt )
-    >r over [ find drop ] dip r> swap pick
-    (find-relative) ; inline
+: find-nth ( seq quot n -- i elt )
+    [ <enum> >alist ] 2dip -rot
+    '[ _ [ second @ ] find-from rot drop swap 1+ ]
+    [ f 0 ] 2dip times drop first2 ; inline
 
-: (find-all) ( n seq quot -- )
-    2dup >r >r find-from [
-        dupd 2array , 1+ r> r> (find-all)
-    ] [
-        r> r> 3drop
-    ] if* ; inline
 
-: find-all ( seq quot -- alist )
-    [ 0 -rot (find-all) ] { } make ; inline
-
-: (find-nth) ( offset seq quot n count -- obj )
-    >r >r [ find-from ] 2keep 4 npick [
-        r> r> 1+ 2dup <= [
-            4drop
-        ] [
-            >r >r >r >r drop 1+ r> r> r> r>
-            (find-nth)
-        ] if
+: find-first-name ( str vector -- i/f tag/f )
+    [ >lower ] dip [ name>> = ] with find ; inline
+
+: find-matching-close ( str vector -- i/f tag/f )
+    [ >lower ] dip
+    [ [ name>> = ] [ closing?>> ] bi and ] with find ; inline
+
+: find-between* ( i/f tag/f vector -- vector )
+    pick integer? [
+        rot tail-slice
+        >r name>> r>
+        [ find-matching-close drop dup [ 1+ ] when ] keep
+        swap [ head ] [ first ] if*
     ] [
-        2drop r> r> 2drop
+        3drop V{ } clone
     ] if ; inline
+    
+: find-between ( i/f tag/f vector -- vector )
+    find-between* dup length 3 >= [
+        [ rest-slice but-last-slice ] keep like
+    ] when ; inline
 
-: find-nth ( seq quot n -- i elt )
-    0 -roll 0 (find-nth) ; inline
+: find-between-first ( string vector -- vector' )
+    [ find-first-name ] keep find-between ; inline
+
+: find-between-all ( vector quot -- seq )
+    [ [ [ closing?>> not ] bi and ] curry find-all ] curry
+    [ [ >r first2 r> find-between* ] curry map ] bi ; inline
 
-: find-nth-relative ( seq quot n offest -- i elt )
-    >r [ find-nth ] 3keep 2drop nip r> swap pick
-    (find-relative) ; inline
 
 : remove-blank-text ( vector -- vector' )
     [
-        dup name>> text = [
-            text>> [ blank? ] all? not
-        ] [
-            drop t
-        ] if
+        dup name>> text =
+        [ text>> [ blank? ] all? not ] [ drop t ] if
     ] filter ;
 
 : trim-text ( vector -- vector' )
     [
-        dup name>> text = [
-            [ [ blank? ] trim ] change-text
-        ] when
+        dup name>> text =
+        [ [ [ blank? ] trim ] change-text ] when
     ] map ;
 
 : find-by-id ( id vector -- vector )
@@ -68,53 +67,22 @@ TUPLE: link attributes clickable ;
     [ attributes>> "class" swap at = ] with filter ;
 
 : find-by-name ( str vector -- vector )
-    >r >lower r>
-    [ name>> = ] with filter ;
-
-: find-first-name ( str vector -- i/f tag/f )
-    >r >lower r>
-    [ name>> = ] with find ;
-
-: find-matching-close ( str vector -- i/f tag/f )
-    >r >lower r>
-    [ [ name>> = ] keep closing?>> and ] with find ;
+    [ >lower ] dip [ name>> = ] with filter ;
 
 : find-by-attribute-key ( key vector -- vector )
-    >r >lower r>
+    [ >lower ] dip
     [ attributes>> at ] with filter
     sift ;
 
 : find-by-attribute-key-value ( value key vector -- vector )
-    >r >lower r>
+    [ >lower ] dip
     [ attributes>> at over = ] with filter nip
     sift ;
 
 : find-first-attribute-key-value ( value key vector -- i/f tag/f )
-    >r >lower r>
+    [ >lower ] dip
     [ attributes>> at over = ] with find rot drop ;
 
-: find-between* ( i/f tag/f vector -- vector )
-    pick integer? [
-        rot tail-slice
-        >r name>> r>
-        [ find-matching-close drop dup [ 1+ ] when ] keep
-        swap [ head ] [ first ] if*
-    ] [
-        3drop V{ } clone
-    ] if ;
-    
-: find-between ( i/f tag/f vector -- vector )
-    find-between* dup length 3 >= [
-        [ rest-slice but-last-slice ] keep like
-    ] when ;
-
-: find-between-first ( string vector -- vector' )
-    [ find-first-name ] keep find-between ;
-
-: find-between-all ( vector quot -- seq )
-    [ [ [ closing?>> not ] bi and ] curry find-all ] curry
-    [ [ >r first2 r> find-between* ] curry map ] bi ;
-
 : tag-link ( tag -- link/f )
     attributes>> [ "href" swap at ] [ f ] if* ;
 
@@ -135,7 +103,7 @@ TUPLE: link attributes clickable ;
     [ dup name>> text = ] prepose find drop ;
 
 : find-opening-tags-by-name ( name seq -- seq )
-    [ [ name>> = ] keep closing?>> not and ] with find-all ;
+    [ [ name>> = ] [ closing?>> not ] bi and ] with find-all ;
 
 : href-contains? ( str tag -- ? )
     attributes>> "href" swap at* [ subseq? ] [ 2drop f ] if ;
@@ -154,7 +122,7 @@ TUPLE: link attributes clickable ;
 
 : find-html-objects ( string vector -- vector' )
     [ find-opening-tags-by-name ] keep
-    [ >r first2 r> find-between* ] curry map ;
+    [ [ first2 ] dip find-between* ] curry map ;
 
 : form-action ( vector -- string )
     [ name>> "form" = ] find nip 

diff --git a/extra/html/parser/parser.factor b/extra/html/parser/parser.factor
index 95bfa938a25b717fe1d595782a5007fd63f4c76a..e084ea6806f3f8f4c48ccb0fd9f2df20239b329e 100644 (file)
--- a/extra/html/parser/parser.factor
+++ b/extra/html/parser/parser.factor
@@ -1,7 +1,8 @@
+! Copyright (C) 2008 Doug Coleman.
+! See http://factorcode.org/license.txt for BSD license.
 USING: accessors arrays html.parser.utils hashtables io kernel
 namespaces make prettyprint quotations sequences splitting
-state-parser strings unicode.categories unicode.case
-sequences.lib ;
+state-parser strings unicode.categories unicode.case ;
 IN: html.parser
 
 TUPLE: tag name attributes text closing? ;

diff --git a/extra/html/parser/utils/utils.factor b/extra/html/parser/utils/utils.factor
index 04b3687f7dd30bcf8d0b2f3cd082b7e3a880bcdc..976a5ba91f6ca8fdf9e108b7bf614f5d2af4639d 100644 (file)
--- a/extra/html/parser/utils/utils.factor
+++ b/extra/html/parser/utils/utils.factor
@@ -1,7 +1,8 @@
+! Copyright (C) 2008 Doug Coleman.
+! See http://factorcode.org/license.txt for BSD license.
 USING: assocs circular combinators continuations hashtables
-hashtables.private io kernel math
-namespaces prettyprint quotations sequences splitting
-state-parser strings sequences.lib ;
+hashtables.private io kernel math namespaces prettyprint
+quotations sequences splitting state-parser strings ;
 IN: html.parser.utils
 
 : string-parse-end? ( -- ? ) get-next not ;