]> gitweb.factorcode.org Git - factor.git/commitdiff
mason.release: Sign the .dmg on macOS.
authorDoug Coleman <doug.coleman@gmail.com>
Wed, 14 Mar 2018 19:07:30 +0000 (14:07 -0500)
committerDoug Coleman <doug.coleman@gmail.com>
Wed, 14 Mar 2018 19:07:30 +0000 (14:07 -0500)
Fixes #1896.

extra/mason/release/release.factor
extra/mason/release/sign/sign.factor

index 49f97171c573e8580e7cf9197fe9ac8514ce6545..3e58c5cb0e4406620e3ca13b21ce1b37f253f4ad 100644 (file)
@@ -12,6 +12,7 @@ IN: mason.release
     sign-factor-app
     archive-name {
         [ make-archive ]
+        [ sign-archive ]
         [ upload ]
         [ save-archive ]
         [ notify-release ]
index fa330e3eb6dc28f64ccd9ec879d489c885bd7897..9608bdf7072935744ffbee6fe7a0ceb813be52eb 100644 (file)
@@ -47,3 +47,18 @@ M:: windows sign-factor-app ( -- )
             }
         ] dip make-factor-path suffix short-running-process
     ] each ;
+
+HOOK: sign-archive os ( path -- )
+
+M: object sign-archive drop ;
+
+! Sign the .dmg on macOS as well to avoid Gatekeeper marking
+! the xattrs as quarantined.
+! https://github.com/factor/factor/issues/1896
+M: macosx sign-archive ( path -- )
+    ${
+        "codesign" "--force" "--sign"
+        "Developer ID Application"
+        cert-path
+    } swap suffix
+    short-running-process ;