http: Use Uppercase For Header Names

They get normalized anyway but most clients seem to use Upper Case.

diff --git a/basis/http/client/client-tests.factor b/basis/http/client/client-tests.factor
index ceab96a6d96bb6de01d752dfcc774d656879ed4d..5d8e11aaaa0a5f00ce1561912fb168b91d26d354 100644 (file)
--- a/basis/http/client/client-tests.factor
+++ b/basis/http/client/client-tests.factor
@@ -14,7 +14,7 @@ IN: http.client.tests
         { method "GET" }
         { version "1.1" }
         { cookies V{ } }
-        { header H{ { "connection" "close" } { "user-agent" "Factor http.client" } } }
+        { header H{ { "Connection" "close" } { "User-Agent" "Factor http.client" } } }
         { redirects 10 }
     }
 } [
@@ -29,7 +29,7 @@ IN: http.client.tests
         { method "GET" }
         { version "1.1" }
         { cookies V{ } }
-        { header H{ { "connection" "close" } { "user-agent" "Factor http.client" } } }
+        { header H{ { "Connection" "close" } { "User-Agent" "Factor http.client" } } }
         { redirects 10 }
     }
 } [

diff --git a/basis/http/client/client.factor b/basis/http/client/client.factor
index 9acdd247d6fab4f800177d0172829645e52d6fdb..3b8e30642aecf202ea520974eeb0cf475a9056eb 100644 (file)
--- a/basis/http/client/client.factor
+++ b/basis/http/client/client.factor
@@ -57,10 +57,10 @@ ERROR: download-failed response ;
     ] if ;
 
 : set-host-header ( request header -- request header )
-    over url>> unparse-host "host" pick set-at ;
+    over url>> unparse-host "Host" pick set-at ;
 
 : set-cookie-header ( header cookies -- header )
-    unparse-cookie "cookie" pick set-at ;
+    unparse-cookie "Cookie" pick set-at ;
 
 : ?set-basic-auth ( header url name -- header )
     swap [

diff --git a/basis/http/http.factor b/basis/http/http.factor
index e0f8528f8dbbd7fd561932ed909848be358c8ddf..43420af92e2113fb05f4b9feb5e8027d464d7f6a 100644 (file)
--- a/basis/http/http.factor
+++ b/basis/http/http.factor
@@ -160,8 +160,8 @@ TUPLE: request
         <url> >>proxy-url
         H{ } clone >>header
         V{ } clone >>cookies
-        "close" "connection" set-header
-        "Factor http.client" "user-agent" set-header
+        "close" "Connection" set-header
+        "Factor http.client" "User-Agent" set-header
         max-redirects >>redirects ;
 
 : header ( request/response key -- value )
@@ -183,9 +183,9 @@ TUPLE: response
     response new
         "1.1" >>version
         H{ } clone >>header
-        "close" "connection" set-header
-        now timestamp>http-string "date" set-header
-        "Factor http.server" "server" set-header
+        "close" "Connection" set-header
+        now timestamp>http-string "Date" set-header
+        "Factor http.server" "Server" set-header
         utf8 >>content-encoding
         V{ } clone >>cookies ;
 

diff --git a/extra/visionect/visionect.factor b/extra/visionect/visionect.factor
index c4e159b2ba88ad8dbdc79e1ceb9be6f182c3aea5..5ae0a01357de8e1d26d67b89583606db9c7b126e 100644 (file)
--- a/extra/visionect/visionect.factor
+++ b/extra/visionect/visionect.factor
@@ -29,8 +29,8 @@ SYMBOL: visionect-api-secret
     visionect-api-key get ":" rot 3append ;
 
 : set-visionect-headers ( request -- request )
-    now timestamp>http-string "date" set-header
-    dup visionect-authorization "authorization" set-header ;
+    now timestamp>http-string "Date" set-header
+    dup visionect-authorization "Authorization" set-header ;
 
 : visionect-request ( request -- data )
     set-visionect-headers http-request nip ;
@@ -50,7 +50,7 @@ SYMBOL: visionect-api-secret
 : visionect-post ( post-data path -- data )
     visionect-url <post-request>
     dup post-data>> dup post-data?
-    [ content-type>> "content-type" set-header ] [ drop ] if
+    [ content-type>> "Content-Type" set-header ] [ drop ] if
     visionect-request ;
 
 PRIVATE>